test_runner: add mock-timers support for AbortSignal.timeout by DeveloperViraj · Pull Request #60751 · nodejs/node

DeveloperViraj · 2025-11-16T17:55:20Z

This PR completes the fix for making AbortSignal.timeout() compatible with
the test runner's mock timers, and adds a regression test to ensure correct
behavior going forward.

What’s included

1. Mock timers fix

Added "AbortSignal.timeout" as a discrete mock-timers API target.
Implemented dedicated store/restore handlers for the original
AbortSignal.timeout property (no silent failures).
Integrated the mock implementation into the toFake/toReal paths to match
the design of other mockable timer APIs.
Restored documentation comments and internal validation that were
unintentionally removed earlier.

2. New regression test

Added test/parallel/test-mock-timers-abortsignal-timeout.js
Verifies that:
- enabling mock timers with { apis: ['AbortSignal.timeout'] } works
- mock.tick() correctly triggers abortion after the expected delay

Notes

I created a fresh branch to ensure a clean diff without unrelated changes and
to fully incorporate the feedback from @Renegade334 and @ErickWendel.

Please let me know if you'd like any adjustments to the test or implementation.
Thanks for the clear guidance and review support

nodejs-github-bot · 2025-11-16T17:55:25Z

Review requested:

@nodejs/test_runner

DeveloperViraj · 2025-11-16T17:58:26Z

Hi @Renegade334 @ErickWendel 👋

I’ve opened a fresh PR with a clean branch so it’s easier to review.
All the requested changes have been applied, including the dedicated API
target for AbortSignal.timeout and the new regression test.

Please let me know if anything needs adjusting, happy to update it!
Thanks again for the guidance. 🙏

codecov · 2025-11-16T19:50:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (3330e5c) to head (177ab11).
⚠️ Report is 1079 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60751      +/-   ##
==========================================
+ Coverage   88.54%   89.62%   +1.08%     
==========================================
  Files         703      706       +3     
  Lines      208252   219181   +10929     
  Branches    40153    41988    +1835     
==========================================
+ Hits       184391   196441   +12050     
+ Misses      15869    14617    -1252     
- Partials     7992     8123     +131

Files with missing lines	Coverage Δ
lib/internal/test_runner/mock/mock_timers.js	`98.76% <100.00%> (+0.07%)`	⬆️

... and 438 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DeveloperViraj · 2025-11-16T20:52:39Z

I've updated both the implementation and the regression test:

Fixed the missing function name & trailing comma issues in mock_timers.js

Cleaned up unused variables

Ensured the mock AbortSignal.timeout() matches Node.js behavior

Updated the test file to avoid restricted syntax and comply with Node’s linting rules

The PR is ready for the next round of review
Let me know if you’d like any additional adjustments!

Renegade334

This is looking good! Just a couple of recommended tweaks.

StefanStojanovic

LGTM. Make sure you fix issues found by the linter.

DeveloperViraj · 2025-11-17T12:56:26Z

All requested updates have now been applied.

Summary of changes:

Updated mock_timers.js according to the reviewer’s feedback

Preserved the required comment and applied all suggested code adjustments

Updated the test file to follow the Node.js test style (including loading common first)

Verified everything locally, all lint issues are resolved

@StefanStojanovic @Renegade334
Please let me know if anything else is needed. Thanks for the review and guidance!

DeveloperViraj · 2025-11-18T12:23:08Z

@Renegade334
Just a quick follow-up, I’ve applied all the requested changes and fixed all lint issues locally.
If you get a moment, could you please take another look and let me know if anything else is needed?
Thanks a lot for your time and guidance!

…al.timeout test

DeveloperViraj · 2025-12-01T10:40:16Z

Hi @Renegade334

I’ve addressed the requested changes:

Reverted the EnableOptions typedef to the narrower SupportedApis version

Updated the AbortSignal.timeout test to use the public mock API from node:test

Removed internal imports and the unused variable as suggested

Everything should now align with the review feedback.
Please let me know if anything else needs adjusting.

Stale

JakobJingleheimer · 2026-02-23T22:25:47Z

@DeveloperViraj I think this is very close to landing. One of the items from René #60751 (comment) I consider not a nit. Could you take a look at it? 🙂

Renegade334 · 2026-04-20T15:39:43Z

Let's get this over the line.

Co-authored-by: René <[email protected]>

nodejs-github-bot · 2026-04-20T18:15:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72806/

JakobJingleheimer

🙌

JakobJingleheimer · 2026-04-22T19:32:46Z

Suggested change

value(delay) {

Looks like GH is have a wee stroke with the diffs

JakobJingleheimer · 2026-04-22T19:38:51Z

nit: the current looks a bit weird.

Suggested change

mock.#setTimeout(

() => controller.abort,

delay,

);

Looks like GH is have a wee stroke with the diffs

JakobJingleheimer · 2026-04-22T19:41:10Z

Thank you @Renegade334 for getting this across, and Viraj for the original work.

nodejs-github-bot · 2026-04-22T20:04:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/60751
✔  Done loading data for nodejs/node/pull/60751
----------------------------------- PR info ------------------------------------
Title      test_runner: add mock-timers support for AbortSignal.timeout (#60751)
Author     Viraj Jadhav <[email protected]> (@DeveloperViraj, first-time contributor)
Branch     DeveloperViraj:fix/mock-timers-abortsignal-timeout-v3 -> nodejs:main
Labels     semver-minor, needs-ci, commit-queue-squash, test_runner
Commits    4
 - test_runner: add mock-timers support for AbortSignal.timeout
 - test_runner: revert EnableOptions typedef change and update AbortSign…
 - Apply suggestions from code review
 - remove CRLF introduced by GitHub code review
Committers 3
 - DeveloperViraj <[email protected]>
 - GitHub <[email protected]>
 - Renegade334 <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/60751
Fixes: https://github.com/nodejs/node/issues/60509
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60751
Fixes: https://github.com/nodejs/node/issues/60509
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 16 Nov 2025 17:55:20 GMT
   ✔  Approvals: 4
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/60751#pullrequestreview-3472027080
   ✔  - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/60751#pullrequestreview-3472099714
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/60751#pullrequestreview-4141405569
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/60751#pullrequestreview-4157423483
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-20T18:15:20Z: https://ci.nodejs.org/job/node-test-pull-request/72806/
- Querying data for job/node-test-pull-request/72806/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @DeveloperViraj([email protected])
   ⚠  - commit 9ffc42dd8217 is authored by [email protected]
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/24799848306

PR-URL: #60751 Fixes: #60509 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: René <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

Renegade334 · 2026-04-22T20:21:14Z

Landed in d1ac02f

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 16, 2025

DeveloperViraj changed the title ~~test_runner: fix AbortSignal.timeout mock-timers support and add regression test~~ test_runner: add mock-timers support for AbortSignal.timeout Nov 16, 2025

DeveloperViraj force-pushed the fix/mock-timers-abortsignal-timeout-v3 branch 2 times, most recently from 8cbc185 to 1b2d32f Compare November 16, 2025 20:49

MoLow approved these changes Nov 17, 2025

View reviewed changes

Renegade334 reviewed Nov 17, 2025

View reviewed changes

Comment thread lib/internal/test_runner/mock/mock_timers.js Outdated

Comment thread lib/internal/test_runner/mock/mock_timers.js

StefanStojanovic approved these changes Nov 17, 2025

View reviewed changes

test_runner: add mock-timers support for AbortSignal.timeout

ef06137

DeveloperViraj force-pushed the fix/mock-timers-abortsignal-timeout-v3 branch from 1b2d32f to ef06137 Compare November 17, 2025 12:50

Renegade334 previously requested changes Dec 1, 2025

View reviewed changes

Comment thread lib/internal/test_runner/mock/mock_timers.js

Comment thread test/parallel/test-mock-timers-abortsignal-timeout.js Outdated

Comment thread test/parallel/test-mock-timers-abortsignal-timeout.js Outdated

test_runner: revert EnableOptions typedef change and update AbortSign…

fb02de7

…al.timeout test

Renegade334 reviewed Dec 11, 2025

View reviewed changes

Comment thread test/parallel/test-mock-timers-abortsignal-timeout.js Outdated

Comment thread lib/internal/test_runner/mock/mock_timers.js

JakobJingleheimer mentioned this pull request Feb 23, 2026

Node.js Test Runner Meeting 2026-02-23 nodejs/test-runner#16

Closed

JakobJingleheimer added this to Test Runner Board Feb 23, 2026

JakobJingleheimer moved this to In Progress in Test Runner Board Feb 23, 2026

JakobJingleheimer moved this from In Progress to Stuck in Test Runner Board Feb 23, 2026

Apply suggestions from code review

9ffc42d

Co-authored-by: René <[email protected]>

Renegade334 added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 20, 2026

Renegade334 approved these changes Apr 20, 2026

View reviewed changes

Renegade334 requested a review from JakobJingleheimer April 20, 2026 15:43

Renegade334 moved this from Stuck to In Progress in Test Runner Board Apr 20, 2026

This comment was marked as outdated.

Sign in to view

Renegade334 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 20, 2026

Renegade334 self-assigned this Apr 20, 2026

remove CRLF introduced by GitHub code review

177ab11

Renegade334 force-pushed the fix/mock-timers-abortsignal-timeout-v3 branch from 1f622a9 to 177ab11 Compare April 20, 2026 18:13

JakobJingleheimer approved these changes Apr 22, 2026

View reviewed changes

JakobJingleheimer added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 22, 2026

Renegade334 moved this from In Progress to Done in Test Runner Board Apr 22, 2026

Renegade334 closed this Apr 22, 2026

Renegade334 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 22, 2026

+              mock.#setTimeout(
+                () => controller.abort,
+                delay,
+              );

Uh oh!

Conversation

DeveloperViraj commented Nov 16, 2025

What’s included

Notes

Uh oh!

nodejs-github-bot commented Nov 16, 2025

Uh oh!

DeveloperViraj commented Nov 16, 2025

Uh oh!

codecov Bot commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DeveloperViraj commented Nov 16, 2025

Uh oh!

Renegade334 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

StefanStojanovic left a comment

Choose a reason for hiding this comment

Uh oh!

DeveloperViraj commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes:

Uh oh!

DeveloperViraj commented Nov 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DeveloperViraj commented Dec 1, 2025

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer commented Feb 23, 2026

Uh oh!

Renegade334 commented Apr 20, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Apr 20, 2026

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer commented Apr 22, 2026

Uh oh!

nodejs-github-bot commented Apr 22, 2026

Uh oh!

Renegade334 commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Nov 16, 2025 •

edited

Loading

DeveloperViraj commented Nov 17, 2025 •

edited

Loading